Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request:support chinese type in search field #129

Closed
Ti800 opened this issue Jun 27, 2020 · 6 comments
Closed

Request:support chinese type in search field #129

Ti800 opened this issue Jun 27, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@Ti800
Copy link

Ti800 commented Jun 27, 2020

im so lucky that find the incrediable app.❤

@Ti800
Copy link
Author

Ti800 commented Jun 27, 2020

it seems like a bug that cant activate typing mode correctly.
while opening the setting,its working again.
截屏2020-06-27 下午4 54 09

@p0deje
Copy link
Owner

p0deje commented Jun 27, 2020

I'm sorry, but what is the exact issue? Can you give me any steps to reproduce?

@p0deje p0deje added the bug Something isn't working label Jun 27, 2020
@Ti800
Copy link
Author

Ti800 commented Jun 28, 2020

屏幕录制2020-06-28 上午8 45 47
1.Open app, if you are typing in alphabet,it would be ok even without typing mode.
屏幕录制2020-06-28 上午8 58 54
2.i was forced to quit typing mode when typing space.

@p0deje
Copy link
Owner

p0deje commented Jul 10, 2020

I've started an attempt to make it work but got into a rabbit hole. Here are some observations on what I did and what are the problems:

  1. Ideally, instead of manually appending the queryField.stringValue from Carbon event we receive, we'd just make queryField first responder and let the event be handled by AppKit. This would automatically support custom input popovers like Chinese or when one press e for few seconds.
  2. It's not possible to make queryField first responder because menu bar apps are not activated when menu is opened. From AppKit perspective, such apps ignore all the events.
  3. To make queryField first responder, we can force-activate the app when menu opens. When activation happens, the menu is immediately closed.
  4. To workaround the issue, we can activate and popup menu using DispatchQueue.main.async. For some reason, it works.
  5. Even with all these hacks, we have to activate a previous application after menu is closed. So far I haven't found a way to make it work with pasting functionality.

Some progress can be seen in 6d1f144, but I am no longer sure I can make it work reliably. I've already spent hours piling one hack over another 😞

@extimo
Copy link

extimo commented Jul 15, 2020

I need this feature too, thanks so much @p0deje

@p0deje p0deje closed this as completed in 0e1cb74 Aug 5, 2020
@p0deje
Copy link
Owner

p0deje commented Aug 7, 2020

Released in 0.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants