Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider to adjust a much reasonable default value for history size #48

Closed
leesiongchan opened this issue Sep 26, 2019 · 2 comments
Closed

Consider to adjust a much reasonable default value for history size #48

leesiongchan opened this issue Sep 26, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@leesiongchan
Copy link

I find it the default value for history size 999 is a little unnecessary and causing the app to be frozen while open up the app, maybe 100 is a good default setting?
@p0deje
Copy link
Owner

p0deje commented Sep 26, 2019

I was also think about decreasing the amount. I'll see what is the maximum number that doesn't cause any performance issues.

However, I've never seen the app really being frozen while open up. Can you elaborate on this bug?

@p0deje p0deje added the enhancement New feature or request label Sep 26, 2019
@p0deje
Copy link
Owner

p0deje commented Sep 27, 2019

I stop seeing any slowdown using fuzzy search with 200 records, so let's set it as default.

@p0deje p0deje closed this as completed in 4b114d9 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leesiongchan @p0deje