Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When opened using hotkey, app is unaware of the edge of a screen #707

Closed
2 tasks done
iparr opened this issue Jan 17, 2024 · 3 comments · Fixed by #709
Closed
2 tasks done

When opened using hotkey, app is unaware of the edge of a screen #707

iparr opened this issue Jan 17, 2024 · 3 comments · Fixed by #709
Labels
bug Something isn't working

Comments

@iparr
Copy link

iparr commented Jan 17, 2024

Before Submitting Your Bug Report

  • I have verified that there isn't already an issue reporting the same bug to prevent duplication.
  • I have seen the FAQ.

Maccy Version (see 'About' window)

0.29.3

macOS Version

14.2.1

Maccy Settings

{
    "KeyboardShortcuts_delete" = "{\\"carbonKeyCode\\":51,\\"carbonModifiers\\":2048}";
    "KeyboardShortcuts_pin" = "{\\"carbonKeyCode\\":35,\\"carbonModifiers\\":2048}";
    "KeyboardShortcuts_popup" = "{\\"carbonModifiers\\":768,\\"carbonKeyCode\\":7}";
    "LaunchAtLogin__hasMigrated" = 1;
    "NSStatusItem Preferred Position Item-0" = 506;
    "NSWindow Frame SUStatusFrame" = "538 608 400 134 0 0 1512 944 ";
    "NSWindow Frame SUUpdateAlert" = "418 409 620 398 0 0 1512 944 ";
    "NSWindow Frame com.sindresorhus.Preferences.FrameAutosaveName" = "963 746 542 435 0 0 2560 1415 ";
    "NSWindow Frame com.sindresorhus.Settings.FrameAutosaveName" = "972 870 442 322 0 0 2560 1415 ";
    SUEnableAutomaticChecks = 1;
    SUHasLaunchedBefore = 1;
    SULastCheckTime = "2024-01-17 12:22:10 +0000";
    SUSendProfileInfo = 0;
    SUUpdateGroupIdentifier = 4160894772;
    WebKitDefaultFontSize = 13;
    WebKitJavaScriptEnabled = 0;
    WebKitPluginsEnabled = 0;
    WebKitStandardFont = "-apple-system-font";
    WebKitUserStyleSheetEnabledPreferenceKey = 1;
    WebKitUserStyleSheetLocationPreferenceKey = "/Applications/Maccy.app/Contents/Frameworks/Sparkle.framework/Resources/ReleaseNotesColorStyle.css";
    clearSystemClipboard = 1;
    enabledPasteboardTypes =     (
        "public.tiff",
        "public.png",
        "public.utf8-plain-text",
        "public.file-url",
        "public.html",
        "public.rtf"
    );
    ignoreEvents = 0;
    ignoredPasteboardTypes =     (
        "com.agilebits.onepassword",
        "net.antelle.keeweb",
        "Pasteboard generator type",
        "com.typeit4me.clipping",
        "de.petermaurer.TransientPasteboardType"
    );
    migrations =     {
        "2020-04-25-allow-custom-ignored-types" = 1;
        "2020-06-19-use-keyboardshortcuts" = 1;
        "2020-09-01-ignore-keeweb" = 1;
        "2021-02-20-allow-to-customize-supported-types" = 1;
        "2021-06-28-add-title-to-history-item" = 1;
        "2021-10-16-remove-dynamic-pasteboard-types" = 1;
        "2022-08-01-rename-suppress-clear-alert" = 1;
        "2022-11-14-add-html-rtf-to-supported-types" = 1;
        "2023-01-22-add-regexp-search-mode" = 1;
    };
    showRecentCopyInMenuBar = 0;
    suppressClearAlert = 1;
}

Description

When I use a shortcut (in my case shift cmd x) to open the Maccy window it opens where the cursor is. But unlike native menus it will not take the edge of the screen into account.

This means that the window will overflow outside of the screen. It's hard to read out there in the void!

Screenshot 2024-01-17 at 12 27 54

Ideally this should act like any other contextual window and if it's too near the right of the screen, it will open to the left of the cursor instead.

This happens on my external monitor setup, but when I unplug the monitor from my M1 Mac Pro the same behaviour is visible.

(This is a wonderful app btw, thanks for it)

Steps to Reproduce

  1. Populate Maccy clipboard with some (any) items.
  2. Move cursor ~100px from right of screen.
  3. Observe Maccy opening to right of cursor but unreadable as it disappears beyond the edge of a monitor viewport.
@iparr iparr added the bug Something isn't working label Jan 17, 2024
@p0deje
Copy link
Owner

p0deje commented Jan 17, 2024

@weisJ This looks like a consequence of the manual menu position adjustment you've implemented. Do you know of any way to fix it?

@weisJ
Copy link
Contributor

weisJ commented Jan 18, 2024

I will look into it. Should hopefully be an easy fix.

@iparr
Copy link
Author

iparr commented Jan 22, 2024

Thanks. If it helps with testing this seems to have been fixed in MacOS 14.3 on v0.29.3 regardless (sorry). This is nonsense. It is 'fixed' when there is so much content in Maccy that it needs to overflow horizontally and this corrects the positioning. With a lower number of items in the storage, it is broken as described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants