Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate GNU-style pkcs11.h at compile time #185

Open
ueno opened this issue Aug 17, 2018 · 1 comment
Open

Generate GNU-style pkcs11.h at compile time #185

ueno opened this issue Aug 17, 2018 · 1 comment

Comments

@ueno
Copy link
Member

ueno commented Aug 17, 2018

Currently we use C preprocessor macros to rename symbols/types/struct members in pkcs11.h to match the GNU coding style. These are a bit intrusive and prone to cause name conflicts.

Instead, it would be nice to generate a separate header, say pkcs11-gnu.h, from the header using non-GNU convention at compile time.

Then it could be included from pkcs11.h if the GNU convention is enabled.

@nmav
Copy link
Contributor

nmav commented Aug 19, 2018

That certainly makes sense especially if in the future, the pkcs11.h from the oasis group becomes open-source license friendly. That would allow p11-kit shipping the original header with extensions defined in additional headers (pkcs11x.h and pkcs11-gnu.h)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants