Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions issue causes file descriptor leak and eventual Chromium crash #220

Closed
eblau opened this issue Mar 22, 2019 · 2 comments
Closed

Comments

@eblau
Copy link

eblau commented Mar 22, 2019

I reported this p11-kit related issue to the Chromium team but they stated that the issue needs to be fixed in p11-kit because it is loaded into Chromium. Here's the bug report I filed with them:

https://bugs.chromium.org/p/chromium/issues/detail?id=944529

Steps to reproduce the problem:

  1. Set any CA certificate installed under /etc/ca-certificates/trust-source/anchors/ to only be readable by root.

  2. Start Chromium and observe constant errors like:
    p11-kit: 'ret >=0' not true at loader_load_directory

Running "trust list" will show a similar error.

  1. Continue using Chromium as usual. Within about half to a full day, Chromium will crash with a warning like:

WARNING:shared_memory_posix.cc(386)] Shared memory creation failed; out of file descriptors

At the point, the browser becomes unresponsive with the current tab not reacting. Shortly thereafter, Chromium crashes.

What is the expected behavior?
Chromium should not run out of file descriptors on a system with normal limits such as the 1024 file descriptor limit that is normal for most Linux distributions and was configured on my system.

What went wrong?
It looks like there is some error path being hit in p11-kit within Chromium that is causing a file descriptor leak. Once I fix permissions on the bad certificate, the file descriptor limit is not exceeded and Chromium does not crash.

@ueno
Copy link
Member

ueno commented Mar 22, 2019

It looks like the same issue as:
https://bugzilla.redhat.com/show_bug.cgi?id=1675441
fixed in #215.

@eblau
Copy link
Author

eblau commented Mar 22, 2019

Yes, that does look like the same issue. Thanks for letting me know. I'll try a test after upgrading to the next version of p11-kit after 0.23.15.

@eblau eblau closed this as completed Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants