Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null value for viewId in nextArgs GraphQL query #309

Closed
sandreae opened this issue Mar 22, 2023 · 4 comments
Closed

Handle null value for viewId in nextArgs GraphQL query #309

sandreae opened this issue Mar 22, 2023 · 4 comments

Comments

@sandreae
Copy link
Member

Currently we attempt to parse a null value into a DocumentViewIdScalar which correctly fails, but we would rather continue the request understanding no view id was assigned.

This is a behaviour change introduced when moving to use async-graphql dynamic module and should be reverted.

@adzialocha
Copy link
Member

I guess this is why send-to-node currently fails, right?

Running `target/debug/send-to-node -k ./key-demo.txt`
▶ Public Key: "2f8e50c2ede6d936ecc3144187ff1c273808185cfbc5ff3d3748d1ff7353fc96"
thread 'main' panicked at 'GraphQL query to fetch `nextArgs` failed:
GQLClient Error: Look at json field for more details
Message: Expected a valid document view id, found: null
', src/main.rs:110:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@sandreae
Copy link
Member Author

sandreae commented Mar 23, 2023

Yes! It's fixed in #308 I'll cherry-pick the commit across to main now.

@sandreae
Copy link
Member Author

Should be fixed with this: 89ff11e

@adzialocha
Copy link
Member

Amazing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants