Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully disconnect peers when shutting down application #402

Closed
adzialocha opened this issue Jun 3, 2023 · 1 comment · Fixed by #387
Closed

Gracefully disconnect peers when shutting down application #402

adzialocha opened this issue Jun 3, 2023 · 1 comment · Fixed by #387

Comments

@adzialocha
Copy link
Member

adzialocha commented Jun 3, 2023 •
edited
Loading

When shutting down a node all other connected peers will not be informed about them going offline, they currently time out the connection after some seconds.

More friendly we should inform all peers about our node shutting down by properly closing the connection before.
@adzialocha adzialocha added this to the Replication protocol milestone Jun 3, 2023
@adzialocha
Copy link
Member Author

I've made some hacky experiments which worked, will refactor and push

@adzialocha adzialocha mentioned this issue Jun 3, 2023
Closed
@adzialocha adzialocha linked a pull request Jun 18, 2023 that will close this issue
Integrate replication manager with networking stack #387
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate replication manager with networking stack p2panda/aquadoggo
1 participant
@adzialocha