Using sar_disable_challenge_stats_hud 1 results in same voice line

[PortalRex]

Having sar_disable_challenge_stats_hud set to a value of 1 results in the voice line "Maybe I was wrong about you" for any finished time. No matter if it was a PB or not.

[PortalRex]

Alternatively having a separate command something like sar_challenge_stats_close <X amount of ms> could be something nice to have as it could be customized more in coop and would possibly fix the voice line issue.

[Krzyhau]

I've tried to fix this by reimplementing sar_disable_challenge_stats_hud to actually open challenge mode HUD for a split second (read the comment in that commit), but that not only seems inconsistent (leaderboards seem to open at random time for whatever reason) but difficult without spending more time on it. Either needs to be investigated again or abandoned completely once we figure out an alternative for in-game leaderboards (leaderboards+ soon? 👀)

[PortalRex]

Alternatively having a separate command something like sar_challenge_stats_close <X amount of ms> could be something nice to have as it could be customized more in coop and would possibly fix the voice line issue.

As talks about Funnel Catch spawns have started one thing that is certain is that if both players wait for the cm menu to pop up the resulting time is almost always a 2.48 (within a tick). Having something that can close the menu after a set amount of time will not only help test the spawns but also probably fix the voice line problem.

[PortalRex]

Technically solved with 48fbab9 but should still be looked into why the old implementation doesn't work.

[ThisAMJ]

So the new approach of waiting after the leaderboard opens to close it works, but now it seems to choose between two voicelines instead (the infamous "maybe i was wrong about you" and "youre getting worse"). based on the observation that the time it takes to open is slightly random (3-4ish ticks after +leaderboard), that leads me to the hypothesis that the voiceline is pseudo-randomized each tick it's visible or exists or something. so if it were never visible it would never randomize and have the same voiceline. i did some investigation a while back and found that m_pLeaderboard->DoGladosSpokenReaction is the relevant function, but I have no source for it.