-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algorithms are registered on the universe but never deregistered #658
Comments
Is this a duplicate of #596? |
Indeed, this is a repeat. So this was never fixed in Algorithm, correct?
+ + + + + + + + + + + + + +
Brian Ruttenberg, PhD
Senior Scientist
Decision Management Systems Division
Government Services
Charles River Analytics Inc.
617.491.3474 x730
www.cra.com<http://www.cra.com/>
From: William Kretschmer [mailto:notifications@github.com]
Sent: Wednesday, January 4, 2017 4:02 PM
To: p2t2/figaro <figaro@noreply.github.com>
Cc: Brian Ruttenberg <bruttenberg@cra.com>; Author <author@noreply.github.com>
Subject: Re: [p2t2/figaro] Algorithms are registered on the universe but never deregistered (#658)
Is this a duplicate of #596<#596>?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#658 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFJOJUB11yLLKJsv_5XoVMFJJtb6UNsiks5rPAjKgaJpZM4La0VM>.
|
No, we haven't fixed this yet. |
bruttenberg
pushed a commit
to bruttenberg/figaro
that referenced
this issue
Jan 10, 2017
…nalytics#659 and charles-river-analytics#660. Issue charles-river-analytics#658 fixed for Importance sampling only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a ProbQueryAlgorithm is created, it is registered on the universe, but when a kill is issued, it is never deregistered. This is a problem when you have many nested inference algorithms. This really should be done at the algorithm level automatically for every algorithm created.
The text was updated successfully, but these errors were encountered: