Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make backbone a peer dependency #95

Closed
craigmichaelmartin opened this issue Jun 17, 2016 · 2 comments
Closed

make backbone a peer dependency #95

craigmichaelmartin opened this issue Jun 17, 2016 · 2 comments

Comments

@craigmichaelmartin
Copy link
Contributor

Is there a reason backbone is listed as a dependency, rather than a peer dependency?
@p3drosola
Copy link
Owner

No good reason at all. PRs welcome

craigmichaelmartin added a commit to craigmichaelmartin/Backbone.VirtualCollection that referenced this issue Jun 22, 2016
@craigmichaelmartin
specify backbone as a peer dependency
d62dffa 
closes p3drosola#95
@craigmichaelmartin craigmichaelmartin mentioned this issue Jun 22, 2016
Closed
craigmichaelmartin added a commit to craigmichaelmartin/Backbone.VirtualCollection that referenced this issue Jun 22, 2016
@craigmichaelmartin
specify backbone as a peer dependency
f576331 
closes p3drosola#95
craigmichaelmartin added a commit to craigmichaelmartin/Backbone.VirtualCollection that referenced this issue Jun 23, 2016
@craigmichaelmartin
specify backbone as a peer dependency
33097b0 
closes p3drosola#95
@p3drosola
Copy link
Owner

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

specify backbone as a peer dependency craigmichaelmartin/Backbone.VirtualCollection
2 participants
@p3drosola @craigmichaelmartin