Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaw in :IsDisenchantable logic when using garrison building and items below level 21 #7

Closed
Blazeflack opened this issue Mar 10, 2015 · 2 comments
Assignees
Labels

Comments

@Blazeflack
Copy link

By default GetSkillRequired returns "1" when quality is 2 and level is below 21.

When using the garrison enchanting building, this leads to :IsDisenhantable to return true for those items, when in fact low level items like that cannot be disenchanted at the garrison building.

@Blazeflack Blazeflack changed the title Flaw in :IsDisenchantable logic when using garrison building and low items Flaw in :IsDisenchantable logic when using garrison building and items below level 21 Mar 10, 2015
@Blazeflack
Copy link
Author

I modified the enchant building return to read

return skillRequired == 1 and not (quality == 2 and level < 21), skillRequired

Which solved it. I don't know if you have a better way to do it.

@p3lim p3lim added the bug label Mar 10, 2015
@p3lim p3lim self-assigned this Mar 10, 2015
@p3lim
Copy link
Member

p3lim commented Jun 20, 2015

Should have been resolved by now, most likely from one of these commits:
ffd2dee
c36316e

Feel free to let me know if it's still not working correctly.

@p3lim p3lim closed this as completed Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants