-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] No longer compatible with the new Tidy5e sheet #34
Comments
Maybe is connected to this kgar/foundry-vtt-tidy-5e-sheets#250 , but you say is not only a visual issue ? is a calculation weight issue ? |
Some more testing has shown me that these are two separate issues. 1. Active effect delayThe delay with applying the active effect is present for me even when Tidy5e is disabled. Active Modules (this is all of them in the test world) Here a screen recording from my test world: Delayed.active.effect.mp4
2. Weight total not updating with Tidy5eWith the same test world, but I enable Tidy5e, then the weight displayed doesn't update correctly. Active Modules The total weight at the bottom of the Tidy5e sheet doesn't update, it stays stuck at the total weight from when I switched the character over to the Tidy5e sheet through the "Sheet" button on the menu bar of the sheet. See screen recording: Display.not.updating.Tidy5e.v1.4.mp4The calculated weight does appear correctly in the console when debugging is active, so this part is just a display issue with Tidy5e v1+. In my test world, the default sheet works as expected even when the Tidy5e module is active (except for the effect delay as shown above). Thus, there could be some other module interfering there (e.g. I also use Item Containers). However, as the issue is with the Tidy5e display, I simply expect that the hooks changed. |
First of all ty very much for the detailed ticket. |
Thank you! |
The bar works well, but for the moment has no effect on movement. |
For me, the text above the bar seems to show the correct current/max weight, and refreshes correctly when items are changed. However, the bar itself is acting strange. The text inside the bar is saying a lower current weight (it seems to not include the weight of "containers" like Backpack, Waterskin, etc). It also isn't refreshing when items in the inventory are changed. The bar itself will stretch to match the correctly displayed current weight value (the one above the bar). Furthermore, the encumberance condition only seems to be given once the value written inside the bar exceeds the breakpoint. This creates a strange scenario where visually the bar can stretch past the breakpoint yet not grant the encumbered condition. And then add to that the issue with the bar not changing color correctly when going past breakpoints. If this module is turned off, Tidy5eSheet will correctly display the weight (with a matching bar), yet of course not apply any conditions. This doesn't seem to be a purely VE-midi & Tidy5eSheet compability issue though, as even the dnd5e 3.0 default sheet has a similar bug in regards to it's weight bar and not including the weight of containers. Module versions: System version: Foundry version: |
I'm getting an issue where if I open a container and then close the sheet, I can no longer open that sheet. So if i open John sheet, mess with a container, then close the sheet. Johns sheet will no longer open unless i refresh. |
Can you spcecify the tidy5e sheet version ? If you click f12 on the web console did you see any red messages ? |
Yeah seeing this behavior for the most part. @p4535992 have you been able to replicate the behavior? |
Can you pass to me the actor json or some screenshot of the logs ? |
@p4535992 Sure thing, here is the actor I am testing with. Seems the issue is mostly the visuals breaking and it does not apply the debuff when the thresholds are crossed. I am using modified values for encumberance so I'm not sure if that could be a difference but everything else should be default. |
Module versions
Variant Encumbrance+Midi v0.15.2
Tidy5e v1.4.0
Describe the bug
Tidy5e development has been taken over and is now available as foundry-vtt-tidy-5e-sheets. This unfortunately seems to break Variant Encumbrance+Midi if tidy5e is active (
doesn't have to be the active sheetEdit: it does have to be the active sheet).I'm using Variant Encumbrance+Midi to make it possible for characters to unequip items and not have it count toward the total weight and then have the encumbered active effect apply automatically.
To Reproduce
Steps to reproduce the behaviour:
See the bar underneath change, butThe bar doesn't change, nor does the total weight (I understood this wrongly the first time around, it was changing due to Item Collections)System
DnD5e v2.4.1
Foundry Version:
v11.315
Browser:
Mozilla Firefox v123.0
The text was updated successfully, but these errors were encountered: