New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen sharing feature UI adjustment and code refactor #12
Conversation
What do you think? @Noth3r Feel free to test and/or give suggestions to it. |
Nice PR. It works perfectly. But I have a little suggestion to stick with the In
|
@Noth3r Nice catch, I didn't even know that. I can't test its performance, but we are definitely scanning a lot of images (when screen sharing) and are having performance issues. I also noticed that by not using a reusable worker, the browser requests the worker file every time it scans a frame or an image (I think this is what causes the higher CPU usage). Let me wire up the changes. |
Does it look good to you? @Noth3r |
Yep works perfectly. Nice one @p4kl0nc4t 🎉 |
Merged, thanks! |
Screen sharing feature UI adjustment and code refactor
In this PR, I tried to tidy things up especially the UI. As a follow-up of #9, in sum, this PR have done the following things:
localStorage
praesentia.js
nimiq/qr-scanner
as it looks quite messy (this should be in another PR, but I guess that's okay)