New feature: log in by using a session token #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two methods have been added to make it possible to log in with a session id and a group id instead of username and password. Signed-off-by: Faiz Jazadi <me@lcat.dev>
This commit have utilized two new methods from the previous commit: `load_session` and `serialize_session`. From this commit, a token will be given everytime a user has successfully logged in (given in the alert window). That token can then be used to login by entering the token into the username field. Signed-off-by: Faiz Jazadi <me@lcat.dev>
ttycelery
added a commit
that referenced
this pull request
Nov 2, 2023
New feature: log in by using a session token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have recently faced a problem where I have to share my username and password when trying to "ensure" my presence.
This PR has mainly changed the logging in logic. This PR contains changes that made it possible to log in with a session token instead of a username and a password. This way, if in some scenario, a user won't have to share their credentials.
A "session token" is actually just a string comprised of a logged in
SimasterQRPresenceinstance'ssession_idandgroup_id. Some new methods (a way to serialize and deserialize a session token) have also been added tosimaster.pyfile.From the front perspective, the
home.htmlhas also been changed. After logging in, there will be a small text displayed on the alert box that contains the last session token.