Change the QR scanning library to nimiq/qr-scanner
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adjusts the necessary files that was previously using `mebas/html5-qrcode`. The adjustments include removing unnecessary css rules, editing the layout of the main page, and adjusting the functions inside `praesentia.js`. This is not final and needs a lot of testing and improvements.
ttycelery
added a commit
that referenced
this pull request
Nov 2, 2023
Change the QR scanning library to `nimiq/qr-scanner`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As a follow-up of #5, this PR removes the implementation of
mebjas/html5-qrcodedue to its unreliability in scanning QR codes especially when the QR code is in a Google Meet screenshot. As its replacement, this PR implementsnimiq/qr-scanneras advised in #5.Some tests have been performed on this implementation. Those tests have proved an increased reliablity when scanning QR code. All QR code that can't be scanned by
mebjas/html5-qrcodecan be scanned by `nimiq/qr-scannerAs a consequence of this library switch, a significant portion of the UI have also been adjusted. The in-place camera scan (provided by default by the previous library) has also been removed and replaced by a classical file input (scanning by camera is still possible, just not directly in the browser).
Fixes: #4 #5
Signed-off-by: Faiz Jazadi me@lcat.dev