-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PSA] Selective dropping of cloned packets in PRE #372
Comments
And by the same token, drop_original(), even though I am not aware of such a use-case. |
@hanw I don't have an answer to this question. Just calling this issue to the attention of Han Wang, who is thinking about PRE issues for PSA. |
To remind everyone about the context, in the last meeting, we voted to use metadata to control the clone operation in PRE. The current thinking is to have a metadata bit that is an Further, the cloned copy of a packet has a metadata bit (to the parser) to identify it as a cloned copy. Therefore, the pipeline can drop the cloned packet by setting the drop_original() can be implemented by setting both the |
drop_all() is encoded as |
Thanks @hanw |
@samar-abdi @hanw With Han's recent changes where when cloning a packet, you also specify whether the packet is the original packet, or the modified packet, I think that should address Samar's question, although having a few more explicit sentences describing this in the PSA spec would be worthwhile. |
Apologies in advance for my limited understanding of PRE.
Is it possible to selectively drop only the cloned packet and not the original? In other words, replacing pre.drop() with pre.drop_all() and pre.drop_cloned()?
The text was updated successfully, but these errors were encountered: