-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image doesn't get committed #14
Comments
I remember having a bug like this did you properly create the assets folder? the nodejs script does not create a assets folder so this might be the issues if after creating the folder the problem is still here you can also try and create a empty thm_propic.png file and then it should find the file to edit but that step should not be needed it's only a problem with the folder not existing if my memory is correct. |
I tried that before opening the issue and it didn't work, but now somehow it worked?😅
|
I also created the https://github.com/Letgamer/Letgamer/blob/main/assets/thm_propic.png and now I get:
It states that the file was modified but it still is the same |
looks like the Problem in #13 |
you should delete that file but keep the folder to see because I think git is getting confused and isnt able to add the file to the commit I don't know what would be causing this. EDIT: so I just checked and I think this problem is actually everywhere because on my repo I have the same error for some reason I think the nodejs version or the git library used might be the issue since I haven't updated them since. I would need to debug this further I'll see when I have time for this and I'll close this issue once it's fixed if someone want's to fix this for me commits are more than welcome :) |
Thanks for helping me out, I really appreciate the workflow :) |
https://github.com/Letgamer/Letgamer
https://github.com/Letgamer/Letgamer/actions/runs/8556624967/job/23446939621
Apparently no commit is made and then the image is of course not found. I don't get why no commit is made, maybe it has todo with wrong permissions
The text was updated successfully, but these errors were encountered: