Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port upstream fix for mcmilk/7-Zip-zstd#131 #27

Closed
ghost opened this issue Jun 3, 2020 · 6 comments
Closed

Port upstream fix for mcmilk/7-Zip-zstd#131 #27

ghost opened this issue Jun 3, 2020 · 6 comments

Comments

@ghost
Copy link

ghost commented Jun 3, 2020

p7zip may also have the same issue as mcmilk/7-Zip-zstd#131 and therefore mcmilk/7-Zip-zstd@9378903 and mcmilk/7-Zip-zstd@256e464 may need to be ported to p7zip.

@ghost ghost changed the title Port upstream commit which fix mcmilk/7-Zip-zstd#131 Port upstream fixes Jun 4, 2020
@jinfeihan57
Copy link
Contributor

mcmilk/7-Zip-zstd#130 p7zip don't have it(I added judgment when porting zstd ).
mcmilk/7-Zip-zstd#133 I think this is a GUI bug. p7zip has no GUI yet. so it not a problem.
You can verify them.Please feedback me in time for any problems.
mcmilk/7-Zip-zstd#131 I will look at it.

@ghost ghost changed the title Port upstream fixes Port upstream fix for mcmilk/7-Zip-zstd#131 Jun 4, 2020
@jinfeihan57
Copy link
Contributor

mcmilk/7-Zip-zstd#131 It was fixed. #29

@ghost
Copy link
Author

ghost commented Jun 4, 2020

Thanks for the fix.

May I ask a question? I am trying to set the parameters but it won't let me. Am I using the correct syntax?
./7z a -m0=zstd test.7z ../CPP: OK
./7z a -m0=zstd:strategy=2 test-st2.7z ../CPP: Error
./7z a -m0=zstd:long test-long.7z ../CPP: Error
./7z a -m0=zstd:WindowLog=10 test-wlog.7z ../CPP: Error

@jinfeihan57
Copy link
Contributor

Old version zstd only support compression level setting.
The latest update supports the parameter setting of zstd. #33
if you want set more parameters please download the latest dev branch.

@jinfeihan57
Copy link
Contributor

ZSTD parameters NEW name:
strategy -> strat
fast -> fast
long -> long
WindowLog -> wlog
HashLog -> hlog
ChainLog -> clog
SearchLog -> slog
MinMatch -> slen
TargetLen -> tlen
OverlapLog -> ovlog
LdmHashLog -> ldmhlog
LdmSearchLength -> ldmslen
LdmBucketSizeLog -> ldmblog
LdmHashRateLog -> ldmhevery

One more thing next time when you have issue or bug, please open a issue or at least reopen it.
Thanks!

@ghost
Copy link
Author

ghost commented Jun 5, 2020

One more thing next time when you have issue or bug, please open a issue or at least reopen it.

OK and sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant