Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Constructor should throw the exception #3

Closed
hkwak opened this issue Oct 24, 2018 · 1 comment
Closed

The Constructor should throw the exception #3

hkwak opened this issue Oct 24, 2018 · 1 comment

Comments

@hkwak
Copy link

hkwak commented Oct 24, 2018

eu-vat-validator/src/Vat/Provider/Europa.php

Line 29 in 7f7b551

exit('Impossible to connect to the europa SOAP : ' . $oExcept->faultstring);

The Constructor should throw the exception (kind of ConnectionNotEstablishedException or ProviderNotAvailableException) not just exit, to allow the outer code to deal with the problem (eg display the error message, retry after some delay, etc)
@pH-7
Copy link
Owner

pH-7 commented Oct 25, 2018

Fixed in #7

@pH-7 pH-7 closed this as completed Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pH-7 @hkwak