You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This library should have it's scraping functionality refactored into a separate class (ScrapingClient?) that can be used without touching the API. The WebClient class can simply instantiate and use that class to extend stravalib's Client class.
This enables the scraping client class to not only extend the API, but to provide scraping-based replacements for other API methods (ie. listing activities, getting activity data, etc). This gives users of the library the choice of using a stravalib-compatible class, or relying completely on scraping and not having to set up an API application at all (a huge pain).
The text was updated successfully, but these errors were encountered:
pR0Ps
linked a pull request
Oct 1, 2020
that will
close
this issue
This library should have it's scraping functionality refactored into a separate class (
ScrapingClient
?) that can be used without touching the API. TheWebClient
class can simply instantiate and use that class to extendstravalib
'sClient
class.This enables the scraping client class to not only extend the API, but to provide scraping-based replacements for other API methods (ie. listing activities, getting activity data, etc). This gives users of the library the choice of using a
stravalib
-compatible class, or relying completely on scraping and not having to set up an API application at all (a huge pain).The text was updated successfully, but these errors were encountered: