Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using the library without API access #4

Open
pR0Ps opened this issue Sep 25, 2020 · 0 comments · May be fixed by #5
Open

Allow using the library without API access #4

pR0Ps opened this issue Sep 25, 2020 · 0 comments · May be fixed by #5

Comments

@pR0Ps
Copy link
Owner

pR0Ps commented Sep 25, 2020

This library should have it's scraping functionality refactored into a separate class (ScrapingClient?) that can be used without touching the API. The WebClient class can simply instantiate and use that class to extend stravalib's Client class.

This enables the scraping client class to not only extend the API, but to provide scraping-based replacements for other API methods (ie. listing activities, getting activity data, etc). This gives users of the library the choice of using a stravalib-compatible class, or relying completely on scraping and not having to set up an API application at all (a huge pain).

@pR0Ps pR0Ps linked a pull request Oct 1, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant