Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CefClientDelegate in several handlers to get a more cef-like implementation. #46

Closed
GoogleCodeExporter opened this issue Feb 18, 2016 · 5 comments

Comments

@GoogleCodeExporter
Copy link

This issue is an enhancement of JCEF (patch 2 of 10)
----------------------------------------------------
Purpose: Split CefClientDelegate in several handlers to
get a more cef-like implementation.

This patch relies on the attached patch file of issue #. 
If you want to try these code changes, add the patch of issue # first and 
afterwards add the patch file attached to this issue. Otherwise you'll get some 
patch-errors.

With this patch, the class CefClientDelegate is divided into the handler 
interfaces
- CefDisplayHandler
- CefRenderHandler
- CefMessageRouterHandler
- CefFocusHandler
to get the JCEF implementation closer to its JNI counterpart CEF.

For each of these interfaces an adapter class is provided which methods are 
empty. 
- CefDisplayHandlerAdapter
- CefRenderHandlerAdapter
- CefMessageRouterHandlerAdapter
- CefFocusHandlerAdapter
These classes exists as convenience for creating handler objects.

CefClient is extended by the methods
- addDisplayHandler(CefDisplayHandler handler)
- removeDisplayHandler()
- addFocusHandler(CefFocusHandler handler)
- removeFocusHandler()
- addMessageRouterHandler(CefMessageRouterHandler handler)
- removeMessageRouterHandler()
- addRenderHandler(CefRenderHandler handler)
- removeRenderHandler()
to add and remove the handler implementations to the client.

Please see attached patch file for further informations.

Original issue reported on code.google.com by k...@censhare.de on 8 Mar 2014 at 7:53

Attachments:

@GoogleCodeExporter
Copy link
Author

This patch relies on the attached patch file of issue #45. 
If you want to try these code changes, add the patch of issue #45 first and 
afterwards add the patch file attached to this issue. Otherwise you'll get some 
patch-errors.

Original comment by k...@censhare.de on 8 Mar 2014 at 7:55

@GoogleCodeExporter
Copy link
Author

Original comment by magreenb...@gmail.com on 12 Mar 2014 at 9:50

@GoogleCodeExporter
Copy link
Author

Original comment by magreenb...@gmail.com on 12 Mar 2014 at 9:51

@GoogleCodeExporter
Copy link
Author

Original comment by magreenb...@gmail.com on 12 Mar 2014 at 9:51

@GoogleCodeExporter
Copy link
Author

Added in revision 33.

Original comment by magreenb...@gmail.com on 28 Mar 2014 at 10:51

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant