Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pa11y-ci should use the puppeteer of pa11y #166

Closed
masi opened this issue Nov 26, 2021 · 1 comment
Closed

pa11y-ci should use the puppeteer of pa11y #166

masi opened this issue Nov 26, 2021 · 1 comment

Comments

@masi
Copy link

masi commented Nov 26, 2021

Both packages have their own dependency on puppeteer. This causes npm to download puppeeteer once for pa11y and once for pa11y-cli.

At least that what happens to me when I have BackstopJS installed as well, which depends on a newer version of puppeteer (10.0.0 at the time of writing).

Sidenote: why does both packages do not depend on puppeteer-core? Then I could use any Chromium I want to.

@josebolos
Copy link
Member

Pa11y-ci v3 now uses the same version of puppeteer than pa11y, so puppeteer will only be installed once.

Regarding the use of puppeteer-core, most of pa11y's usage happens in CI systems and we want to provide a tool that will work out of the box as much as possible. This also help us test pa11y releases and ensure that nothing will break if people choose to use a different Chromium version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants