Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global pa11y-ci configuration options hould not be part of "defaults" #167

Open
masi opened this issue Nov 26, 2021 · 1 comment
Open

global pa11y-ci configuration options hould not be part of "defaults" #167

masi opened this issue Nov 26, 2021 · 1 comment

Comments

@masi
Copy link

masi commented Nov 26, 2021

Setting concurrency, reporters and basic puppeteer options like Chrome flags has IMHO nothing to do with per URL configuration options. IMHO they should be set outside of the "defaults" objects:

{
    'defaults': {
        'timeout': 1000,
        'viewport': {
            'width': 320,
            'height': 480
        },
    },
    'chromeLaunchConfig': {
        'args': ['--no-sandbox']
    },
    concurrency: 5
};

This would make the configuration more clear.

@kant2002
Copy link

The problem even more interesting right now. I see inconsistency of the configuation pa11y and pa11y-ci.

  • pa11y require chromeLaunchConfig to be on the root.
  • pa11y-ci look at chromeLaunchConfig inside defaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants