Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Rules Only Apply to Errors #157

Open
jbuck94 opened this issue Nov 9, 2016 · 7 comments
Open

Ignore Rules Only Apply to Errors #157

jbuck94 opened this issue Nov 9, 2016 · 7 comments

Comments

@jbuck94
Copy link

jbuck94 commented Nov 9, 2016

It seems like ignored rules only apply to errors. Is there a way to set rules in the ignore list to be ignored throughout the system (ie. in Errors, Warnings, and Notices)?

ignored

@rowanmanning
Copy link
Member

Hi @jbuck94, this is odd – Pa11y should ignore warnings and notices as well as errors. I'll take a look for you

@rowanmanning rowanmanning self-assigned this Nov 10, 2016
@jbuck94
Copy link
Author

jbuck94 commented Nov 10, 2016

Thanks! It's only on the dashboard - works correctly when using the CLI. 

@iandevlin
Copy link

For me it appears to ignore the fact that I have told it to ignore a rule.

@rowanmanning
Copy link
Member

Actually looking at this again the ignored rule does not match the code of the error, which is why it's still appearing. It may be that you need to check multiple boxes in the ignored rules section of the task?

@morsmodr
Copy link

morsmodr commented Aug 8, 2017

Ignore rules do not seem to be applied for rules of type: WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.[NodeName].Name

I am currently ignoring Principle 4 as I will be working on that later, but Pa11y is still checking against Principle 4

Highlighted errors are of type [NodeName].Name:
image

Ignore List:
image

@rowanmanning
Copy link
Member

Ah OK, looks like our list of rules is incomplete, we probably need an entry for each type of node.

@mikeya
Copy link

mikeya commented Feb 26, 2021

Can we just make the parser smart enough to check the ignored rules and if they contain [NodeName] ignore for all node types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants