Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage report doesn't seem to be reported for pull requests #86

Closed
libre-man opened this issue Jan 11, 2020 · 5 comments
Closed

Coverage report doesn't seem to be reported for pull requests #86

libre-man opened this issue Jan 11, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@libre-man
Copy link

I think this is related to #42, as the GITHUB_REF environment variable is something else than is expected in the code. Here is the documentation for the environment variables and their value when the action runs for a pull request: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#pull-request-event-pull_request

@paambaati
Copy link
Owner

@libre-man Thanks for reporting; can you turn on debugging with debug: true and then paste the output here?

@paambaati
Copy link
Owner

@libre-man Terribly sorry, but I’ve been unexpectedly busy and looks like the pipeline has expired. I plan to look at this and try to fix this tomorrow, so it’d be great if you can run it again and share the output.

@partydrone
Copy link

partydrone commented Feb 18, 2020

I'm also seeing this issue. It looks like the branch name is not reported correctly. It looks like the branch name reported by the action is for the pull request, not the git branch:

Screen Shot 2020-02-18 at 10 38 11 AM

Here is the relevant bit from my Action logs.

In my particular use case—and having messed around a little with identifying all the ENV vars that get set—GITHUB_HEAD_REF contains the appropriate value for the branch name.

@paambaati
Copy link
Owner

@libre-man @partydrone I've just pushed v2.5.1 with a fix for this. Feel free to reopen this issue if it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants