chore: Add code formatting #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flemzord
approved these changes
Oct 29, 2022
.github/workflows/main.yaml
Outdated
| @@ -8,7 +8,7 @@ on: | |||
| name: Main | |||
| jobs: | |||
| Test: | |||
| name: 'Test' | |||
| name: 'Lint & test' | |||
There was a problem hiding this comment.
I think it would be better to separate it into 2 different jobs.
There was a problem hiding this comment.
I hesitated. Ok. I do it.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| return proxy.web(req, res, { target }); | ||
| } | ||
| return proxy.web(req, res, { target: upstream }); |
Check failure
Code scanning / CodeQL
Server-side request forgery
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problem
There is no formatting rules clearly defined.
It makes it hard to contribute.
Some code changes can be avoid, making code review easier.
🍰 Solution
Add Prettier and
.editorconfigfile.Add 2 npm dev tasks :
format:checkformat:writeInclude
format:checkto CI "Test" job.🚨 Points of interest
🏝️ How to test
Check that the 2 formatting tasks work.
Check that checks are taken into account by GHA.
based on #4 from @flemzord (thanks ❤️ ❤️ ❤️)