Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas FutureWarning #59

Closed
RensDimmendaal opened this issue Jan 26, 2022 · 1 comment
Closed

Pandas FutureWarning #59

RensDimmendaal opened this issue Jan 26, 2022 · 1 comment

Comments

@RensDimmendaal
Copy link
Contributor

RensDimmendaal commented Jan 26, 2022

Hey 馃憢 Thanks for the great package!

I'm encountering the following warning:

/Users/.../.venv/lib/python3.9/site-packages/st_aggrid/__init__.py:253: FutureWarning: Passing a dict as an indexer is deprecated and will raise in a future version. Use a list instead.
  frame.loc[:,text_columns]  = frame.loc[:,text_columns].astype(str)

I'm using the following versions:

  • st_aggrid 0.2.3
  • pandas 1.4.0
  • streamlit 1.4.0

I believe the solution would be to use text_columns.keys() instead of text_columns. And to make similar changes for the other column types in st_aggrid/__init__.py

Happy to submit a PR with these changes if you like.

@PablocFonseca
Copy link
Owner

Thanks!
Yes, please send the PR! I'll include in next version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants