Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make upload also work with manifest not generated via php #5

Open
pablomaurer opened this issue Feb 9, 2017 · 0 comments
Open

make upload also work with manifest not generated via php #5

pablomaurer opened this issue Feb 9, 2017 · 0 comments

Comments

@pablomaurer
Copy link
Owner

pablomaurer commented Feb 9, 2017

comparing logic:

  • hashLocal != hashRemote -> file changed (but local or remote?) -> handle as remote
  • if entry in local manifest BUT not in remote manifest -> delete / new local file -> handle as delete
  • if entry in remote but not in local -> new remote file
  • if local file found not in local manifest -> new local file

But on the second time running this function, and you did not update the manifest, the files are getting uploaded again. I can also not add them to the local file manifest, because it would then delete the new local files.

Maybe it would general be easier to compare lastModified instead hashes, if it's even possible to get everywhere these values?


Since I currently prefer to use the php manifest version, this Issue does not affect me. But feel free to find a solution yourself and send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant