Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the .cpp & .c dependencies back into the repo #3

Merged
merged 1 commit into from Nov 5, 2021

Conversation

johnbanq
Copy link
Contributor

@johnbanq johnbanq commented Nov 5, 2021

This PR aims to fix the missing .cpp & .c files in the external folder, which is caused by the wildcard .c .cpp pattern in .gitignore

So people don't have to go through the grunt work of finding them manually.

I am assuming this fix is desired because the .h & .hh files are still in the repo. If this is not the case, git submodule is another viable alternative.

@pablopalafox
Copy link
Owner

makes sense, thanks @johnbanq!

@pablopalafox pablopalafox merged commit 2d1bce8 into pablopalafox:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants