Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): footer to bottom #20

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

itziarZG
Copy link
Contributor

Hola
No sé si será la mejor manera pero es una manera ;)
Eres mi primera Pull Request además...
Feedback is welcome si prefieres otra manera.

@pablosirera pablosirera changed the base branch from develop to master October 15, 2021 07:04
@pablosirera pablosirera changed the title Fix/footer to bottom fix(ui): footer to bottom Oct 15, 2021
@pablosirera
Copy link
Owner

Funciona perfecto 👍
Lo único que cambiaría sería que el 272px esté en una variable en assets/css/variables.css para definir bien que es, por ejemplo --header-footer-height: 272px y luego usar esa variable en vez de directamente en tamaño

@pablosirera pablosirera added the bug 🐛 Something isn't working label Oct 15, 2021
@netlify
Copy link

netlify bot commented Oct 15, 2021

👷 Deploy request for pablosirera accepted.

🔨 Explore the source changes: 55efb0e

🔍 Inspect the deploy log: https://app.netlify.com/sites/pablosirera/deploys/6169562cf701ac0007404c4d

@itziarZG
Copy link
Contributor Author

Listo con variables, genial idea. Gracias

@pablosirera pablosirera merged commit 8e30ab3 into pablosirera:master Oct 15, 2021
@pablosirera
Copy link
Owner

Muchas gracias @itziarZG 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants