Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic 4 Support #9

Open
SteveKennedy opened this issue Aug 12, 2018 · 2 comments
Open

Ionic 4 Support #9

SteveKennedy opened this issue Aug 12, 2018 · 2 comments

Comments

@SteveKennedy
Copy link

I absolutely love this feature, and have relied on it for building a really cool app for Ionic 2+3.

Ionic 4 no longer supports the full ionic-angular library, and now uses a @ionic/angular library. So when I use this elastic header feature, I get:

[ng] ERROR in node_modules/ionic2-elastic-header/dist/elastic-header.directive.d.ts(2,25): error TS2307: Cannot find module 'ionic-angular'

Any plans to consider to make this Ionic 4 compatible?

@AbbasTallaq
Copy link

Hi,
Find the find file through the error, then modify the lib to this '@ionic/angular', the error will be gone...
however the seems this lib isn't compatible with ionic 4

@BorisRnl
Copy link

BorisRnl commented Mar 9, 2019

It should be possible to use the directive in Ionic 4 with only a few small changes.

Open the directive and change the ‘Content’ import to ‘IonContent’ (in the '@ Input' statement as well).
After that, change ‘ev.scrollTop’ to ‘ev.detail.scrollTop’.

I tried to upload a patch but apparently this is not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants