Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intel compiler warnings in JSON code #102

Closed
paboyle opened this issue May 8, 2017 · 9 comments
Closed

Intel compiler warnings in JSON code #102

paboyle opened this issue May 8, 2017 · 9 comments

Comments

@paboyle
Copy link
Owner

paboyle commented May 8, 2017

I think the warnings under the intel compiler from JSON.hpp are unacceptably high and means we need a release v0.7.1 to fix it.

@paboyle
Copy link
Owner Author

paboyle commented May 8, 2017

Or perhaps I learn how hot fix works more under git flow.
Does this revise a tag ?

@paboyle
Copy link
Owner Author

paboyle commented May 8, 2017

Drat there are other problems that Travis didn't catch under Intel compiler. We definitely need
a resin on v0.7.0 and I was too hasty closing the release.

@aportelli
Copy link
Collaborator

Yes the hot fix does remake a tag when it's closed.

@coppolachan coppolachan self-assigned this May 8, 2017
@coppolachan coppolachan changed the title Intel compiler warnings in JSON code -> v0.7.1 Intel compiler warnings in JSON code May 9, 2017
@coppolachan
Copy link
Collaborator

The issue in the JSON serializer github
nlohmann/json#550

@paboyle
Copy link
Owner Author

paboyle commented May 10, 2017

Since I disabled the intel warning, I will make this not need any further action before 0.7.0

@paboyle
Copy link
Owner Author

paboyle commented May 11, 2017

NB: we will keep issue open until the json issue is resolved and version updated

@paboyle
Copy link
Owner Author

paboyle commented Jun 19, 2017

nlohmann/json#550
Looks like the issue has been resolved on their GitHub, and this is continuing to cause TeamCity to send noisy fail messages. Can you update the JSON please to make the intel compile problem go away ?

@aportelli
Copy link
Collaborator

aportelli commented Jun 19, 2017 via email

@coppolachan
Copy link
Collaborator

coppolachan commented Jul 12, 2017

Closing (not merged in develop yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants