-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider std::array in place of boost::array #2
Comments
Isn't the array template fixed size one dimensional [compile time templated]? Might work for Nd type indices, but not generally usable; secondly the boost array has really nice Another thought is that in general I'm getting quite annoyed that vector resize loops If I remember right, it is an implementation issue: the loop is implemented by This is avoidable with an "is_pod" enable_if in valarray (and possibly vector haven't checked); but So, at some point I may be forced to roll my own "simple" array container that suppresses Question is then whether I make it a multi-dim like boost arrays, or fix to vector like 1d. |
This is the sort of offending loop, that creates a default object and issues a loop void |
sorry for brain dumping Matt -- origin of misunderstanding -- my comments in the http://www.boost.org/doc/libs/1_58_0/libs/multi_array/doc/ which is a very interesting interface. |
Ah sure, I see what you mean. Yeah std::array won't help for multi-dimensional arrays. |
0) We remove lib directory 1) cartesian comm now inherits from shared memory 2) mpit may be wrong, and is unsupported in this grid version 3) similar to paboyle#2, mpi3 is also unsupported 4) the purpose of this commit is to catch up with a year+ of commits from the main develop branch, but still compile with GRID_COMMS_MPI (not MPI3). We want multiple ppn due to contraction tunings (which we have so far been unable to replicate for ppn = 1). Additionally, the mpi3 shared mem options for multiple ppn has only map anon, which will not allow for memory safety when using a shared mem comms buffer (from my recollection). We hope this commit might be useful to other projects which are forced to use multiple ppn (esp. for comms on the KNL. We should recall that the KNL comms may eventually be solved using multi-endpoint, so there may be a limited window for the usefulness of this snapshot.) More testing is needed. Caveat Emptor.
…-norm2 Fused innerProduct + norm2 on first argument operation
You mention boost arrays in the TODO list, so I thought I'd mention this on the off-chance you hadn't already seen it. C++11 provides an array class template that's pretty much the same as the boost array type.
The text was updated successfully, but these errors were encountered: