Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rprofile argument to debian_install #204

Merged
merged 1 commit into from Feb 9, 2021
Merged

Adding rprofile argument to debian_install #204

merged 1 commit into from Feb 9, 2021

Conversation

csgillespie
Copy link
Contributor

@csgillespie csgillespie commented Feb 5, 2021

Provide more flexibility to the Rprofile creation.

  1. The default value should provide the same behaviour, so hopefully not breaking anything.
  2. I did name the repo as CRAN which in theory might someone's set-up, but seems unlikely
  3. Used shQuote() to hopefully avoid quoting chaos.

Related to #202

@sckott sckott added this to the v1.0 milestone Feb 5, 2021
@sckott
Copy link
Collaborator

sckott commented Feb 5, 2021

thanks @csgillespie !

Might it make more sense to have rprofile parameter expect a named list? Then we'd change the default to list(repos=c(CRAN="https://cloud.r-project.org/")) and internally then coerce the named list into a character string. Does that seem like a better or worse option?

@csgillespie
Copy link
Contributor Author

I thought about that, but the downside is we are limiting entries to options(). If we want to add other entries, say functions, then we can't

@sckott
Copy link
Collaborator

sckott commented Feb 5, 2021

right. I guess then it's up to the user to make sure their string is formatted correctly

@csgillespie
Copy link
Contributor Author

@sckott Are you happy to merge?

@sckott sckott merged commit 18bea44 into pachadotdev:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants