Custom, on-prem deployment requires a "persistent-disk-name" that doesn't seem to actually be used in the manifest

[gabrielgrant]

from the on-prem docs:

pachctl deploy custom --persistent-disk google --object-store s3 <persistent disk name> <persistent disk size> <object store bucket> <object store id> <object store secret> <object store endpoint> --static-etcd-volume=${STORAGE_NAME} --dry-run > deployment.json

Note that both a ${STORAGE_NAME} is passed as --static-etcd-volume, and a <persistent disk name> is passed as one of two <persistent disk args> (as referred to on the pachctl deploy custom docs page), but AFAICT only the static-etcd-volume name actually appears in the generated manifest

Wondering if this is a hold-over from the days of deploying a rethink DB?

Related: #2771

[JoeyZwicker]

Is this a docs issue or actually a needed change with the deploy custom command?

[gabrielgrant]

i think it's a change needed in the deploy command to just remove this (seemingly) unused field, but if it used somewhere that i'm missing, then it certainly needs to be better documented

[pappasilenus]

@gabrielgrant @JoeyZwicker I'm documenting this now. I believe this is a holdover from the days before StatefulSets, when we added the required flags to distinguish between a deployment using a Persistent Volume and a StatefulSet: either --dynamic-etcd-nodes and --static-etcd-volume. --static-etcd-volume now takes the argument that used to be this one. I believe we may now safely remove this required, but unused, argument, and only require the parameter for the size of the volume requested.

My document will reflect that it's currently required and reference this issue.