Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4.x backport][Jupyter] Fix datums-related error message when notebooks starts up #8479

Merged
merged 1 commit into from Jan 3, 2023

Conversation

smalyala
Copy link
Contributor

@smalyala smalyala commented Dec 22, 2022

Make datums request at notebooks startup only when connected to a cluster and logged in if auth enabled (when mount server response is 200).

Ticket: https://linear.app/pachyderm/issue/INT-760/error-message-when-starting-up-notebooks

JIRA: INT-782

@smalyala smalyala requested a review from a team as a code owner December 22, 2022 15:42
@smalyala smalyala requested review from albscui and removed request for a team and albscui December 22, 2022 15:42
@codecov
Copy link

codecov bot commented Dec 24, 2022

Codecov Report

Merging #8479 (5229825) into 2.4.x (5229825) will not change coverage.
The diff coverage is n/a.

❗ Current head 5229825 differs from pull request most recent head ce17d01. Consider uploading reports for the commit ce17d01 to get more accurate results

@@           Coverage Diff           @@
##            2.4.x    #8479   +/-   ##
=======================================
  Coverage   38.94%   38.94%           
=======================================
  Files         425      425           
  Lines      117494   117494           
=======================================
  Hits        45761    45761           
  Misses      62651    62651           
  Partials     9082     9082           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@smalyala smalyala merged commit 70db03d into 2.4.x Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants