Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with a better way to do bridge_model_end_yr #1103

Open
cgrandin opened this issue Jan 20, 2024 · 2 comments
Open

Come up with a better way to do bridge_model_end_yr #1103

cgrandin opened this issue Jan 20, 2024 · 2 comments
Assignees

Comments

@cgrandin
Copy link
Collaborator

In doc/load-models.R. Currently it is manually done, and a huge pain to get right

@cgrandin cgrandin added this to the 2025 milestone milestone Jan 20, 2024
@cgrandin cgrandin self-assigned this Jan 20, 2024
@kellijohnson-NOAA
Copy link
Collaborator

Can't we just use the end year of the data file in the loaded model?

find_end_yr <- function(model_list) {
  model_list[["dat"]][["end_yr"]]
}
purrr::map(bridge_models, find_end_yr)

NOTE the above code was not tested it is just what I am thinking 🤔 will work in my head.

@cgrandin
Copy link
Collaborator Author

I know I tried that and there was some reason it wouldn't work, but I will start there. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants