New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing per-migration smoke tests? #196

Open

rod-glover opened this issue Jan 10, 2024 · 0 comments

Contributor

rod-glover commented Jan 10, 2024

Migrations without smoke tests:

3d50ec832e47_add_constraint_on_meta_vars.py
522eed334c85_create_initial_database.py
6cb393f711c3_update_crmpnetworkgeoserver.py
bb2a222a1d4a_convert_obs_count_per_month_history_mv
efde19ea4f52_fix_function_getstationvariabletable.py
fecff1a73d7e_update_matview_collapsed_vars_mv.py

This is quite a few, some reaching far back. (It may be that 522eed334c85_create_initial_database needs no smoke test.)

Question: Is this worth the effort? What is actually tested in the smoke tests that is not effectively tested in the behavioural tests?

Answer: A modest amount. In the case of matviews, it is likely be worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment