Modify from_string for golang purls #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TG1999
requested review from
pombredanne and
tdruez
and removed request for
pombredanne
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
golang_purl_from_string
branch
from
51749fd
to
def9b4e
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne
requested changes
Mar 28, 2023
src/packageurl/__init__.py
Outdated
| @@ -518,7 +518,7 @@ def from_string(cls, purl: str) -> "PackageURL": | |||
| # and the namespace in an npm purl is | |||
| # different from others because it starts with `@` | |||
| # so we need to handle this case separately | |||
| if type == "npm" and path.startswith("@"): | |||
| if type.lower() == "npm" and path.startswith("@"): | |||
There was a problem hiding this comment.
Lower the type earlier only once, since this must be always lowered. Do it there https://github.com/package-url/packageurl-python/pull/115/files#diff-1ac2b399571df74798b2fbfab357ffa8cce45a332f1e69b6f1ccf86811d44ba6R502
src/packageurl/__init__.py
Outdated
| @@ -530,7 +530,10 @@ def from_string(cls, purl: str) -> "PackageURL": | |||
| ns_name_parts = ns_name.split("/") | |||
| ns_name_parts = [seg for seg in ns_name_parts if seg and seg.strip()] | |||
| name = "" | |||
| if not namespace and len(ns_name_parts) > 1: | |||
| if type.lower() == "golang": | |||
There was a problem hiding this comment.
I really do not like these warts for each type: npm, now golang .... sigh ... eventually we will need to bubble these issue up in the spec. They have little impact since they do not change the purl, only how a purl is interpreted.... But for golang there is the issue of legacy that uses a subpath.
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
|
Add migrations, documentation and warnings in CHANGELOG for the above changes. Create a branch for migrations in VCIO, scancode.io and PurlDB for the above changes in golang. |
TG1999
added a commit
to TG1999/packageurl-python
that referenced
this pull request
Dec 8, 2023
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
tdruez
pushed a commit
that referenced
this pull request
Dec 11, 2023
* Revert changes from #115 Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com> * Add CHANGELOG Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com> * Bump version to 0.13.0 Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com> --------- Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 11, 2023
0.12.0 (2023-12-08) ------------------- - Modified `PackageURL.from_string` to properly handle golang purls. package-url/packageurl-python#115 - Improve support for PyPI URLs in `url2purl`. package-url/packageurl-python#128 - Return the "gem" type instead of "rubygems" for "https://rubygems.org/" URLs in `url2purl`. The `pkg:rubygems/` purls are backward-compatible in `purl2url`. package-url/packageurl-python#114 0.11.3 (2023-12-08) -------------------- - Add support for GitLab "/archive/" URLs in `url2purl`. package-url/packageurl-python#133
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 11, 2023
0.13.0 (2023-12-08) - Revert changes from package-url/packageurl-python#115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang packages does not have a definitive way to store namespace and name of a package. sometimes name can have two or more than two '/' separated components and same is also the case for namespace so for that reason we should totally drop namespaces for golang purls and store the whole purl name in name.