Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpagure.Pagure expects '/' not in repo attribute #67

Closed
jpopelka opened this issue May 10, 2019 · 1 comment · Fixed by #71
Closed

libpagure.Pagure expects '/' not in repo attribute #67

jpopelka opened this issue May 10, 2019 · 1 comment · Fixed by #71
Labels
kind/bug Something isn't working. pagure Related to Pagure implementation.

Comments

@jpopelka
Copy link
Member

While debugging packit/packit#305 I realized that it fails because Pagure.create_basic_url() creates:
https://src.fedoraproject.org//api/0/rpms/rpms/packit/pull-requests which does not exist, correct is:
https://src.fedoraproject.org//api/0/rpms/packit/pull-requests.

The problem is that OurPagure.repo attribute has a value rpm/packit, while libpagure probably expects it to be packit only.

Anybody has any idea whether this is a ogr or packit or libpagure issue?
I tend to think it's ogr issue, because OurPagure.repo_name expects / in self.repo, which is probably not what libpagure wants.

And it gets even more puzzled when I tell you that Pagure.create_basic_url() has changed even more recently.

@lachmanfrantisek
Copy link
Member

Anybody has any idea whether this is a ogr or packit or libpagure issue?

Probably the problem in OurPagure or PagureProject in OGR.

And it gets even more puzzled when I tell you that Pagure.create_basic_url() has changed even more recently.

Is this only a formatting change?

It is time to remove libpagure and communicate directly to Pagure API.

@TomasTomecek TomasTomecek added the kind/bug Something isn't working. label May 15, 2019
@lachmanfrantisek lachmanfrantisek mentioned this issue May 29, 2019
2 tasks
@lachmanfrantisek lachmanfrantisek added the pagure Related to Pagure implementation. label May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working. pagure Related to Pagure implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants