Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PagureService: Make retries parametrizable #514

Merged
merged 1 commit into from
Dec 15, 2020
Merged

PagureService: Make retries parametrizable #514

merged 1 commit into from
Dec 15, 2020

Conversation

csomh
Copy link
Contributor

@csomh csomh commented Dec 15, 2020

This way users of a PagureService object can control how failures of API
calls are retried.

Signed-off-by: Hunor Csomortáni csomh@redhat.com

PagureService: Make retries parametrizable
1b2ccf7 
This way users of a PagureService object can control how failures of API
calls are retried.

Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
@packit-as-a-service-stg
Copy link

Congratulations! One of the builds has completed. 🍾

⚠️ Please note that our current plans include removal of these comments in the near future (at least 2 weeks after including this disclaimer), if you have serious concerns regarding their removal or would like to continue receiving them please reach out to us. ⚠️

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/packit-ogr-514-stg
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

lachmanfrantisek
lachmanfrantisek approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Do we want to support this in all implementations?

(I am not sure about your plans, just want to provide as much unified interface as possible for all the forges.)

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@csomh
Copy link
Contributor Author

csomh commented Dec 15, 2020

Thanks!
Do we want to support this in all implementations?

(I am not sure about your plans, just want to provide as much unified interface as possible for all the forges.)

My immediate plan is to use this change in dist2src to retry some of the failures.

In general this would be nice, but as I see the *Service classes share very little in common, and I see no easy way to implement something similar for GitHub and GitLab. An issue like this would be nice for a student to research and implement, though.

@csomh csomh added the mergeit When set, zuul wil gate and merge the PR. label Dec 15, 2020
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 49f79c3 into packit:master Dec 15, 2020
@lachmanfrantisek
Copy link
Member

*Service classes share very little in common

They should. Not the code, but the API.

@mfocko mfocko mentioned this pull request Feb 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachmanfrantisek lachmanfrantisek lachmanfrantisek approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@csomh @lachmanfrantisek