Merge pull request #431 from lachmanfrantisek/copr-targets-not-needed

Copr targets not need to be specified Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
packit · Feb 28, 2020 · 257cb53 · 257cb53
2 parents 857f856 + 33e1e2e
commit 257cb53
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/packit_service/worker/handlers/github_handlers.py b/packit_service/worker/handlers/github_handlers.py
@@ -268,11 +268,6 @@ def __init__(
 
     def handle_pull_request(self):
 
-        if not self.job.metadata.get("targets"):
-            msg = "'targets' value is required in packit config for copr_build job"
-            self.project.pr_comment(self.event.pr_id, msg)
-            return HandlerResults(success=False, details={"msg": msg})
-
         collaborators = self.project.who_can_merge_pr()
         cbh = CoprBuildJobHelper(
             self.config, self.package_config, self.project, self.event

diff --git a/tests/unit/test_copr_build_handler.py → tests/unit/test_build_helper.py b/tests/unit/test_copr_build_handler.py → tests/unit/test_build_helper.py