No need to configure build for tests #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
lachmanfrantisek
force-pushed
the
no-need-for-build-for-tests
branch
from
f2993ee
to
693fc48
Compare
|
Build failed.
|
|
Build failed.
|
lachmanfrantisek
force-pushed
the
no-need-for-build-for-tests
branch
from
23a6a10
to
c492d83
Compare
|
Build failed.
|
lachmanfrantisek
changed the title
|
Build failed.
|
TomasTomecek
approved these changes
Jan 15, 2020
| ), | ||
| ], | ||
| ) | ||
| def test_targets(jobs, build_targets, test_targets): |
Comment on lines
+299
to
+301
| is_copr_build: Callable[ | ||
| [JobConfig], bool | ||
| ] = lambda job: job.type == JobType.copr_build | ||
|
|
||
| if self.job.job == JobType.tests and any( | ||
| filter(is_copr_build, self.package_config.jobs) | ||
| ): |
There was a problem hiding this comment.
I'd write this with a for loop, or at least pass the lambda directly to the filter call
but if you and Jirka think this is fine, let's roll
There was a problem hiding this comment.
It's (currently) impossible to type lambda directly... I would be glad to see a better way to satisfy mypy...
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
lachmanfrantisek
force-pushed
the
no-need-for-build-for-tests
branch
from
bccc7b5
to
40c71a5
Compare
|
Build succeeded.
|
lachmanfrantisek
added
mergeit
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoprBuildHandlertoCoprBuildJobHelperbecause it's not related to theHandlerclasses in the code.TestingFarmJobHelperand share the code with the common superclass of theCoprBuildJobHelper.CoprBuildJobHelperto not need the copr_build job and calculate the right chroots.