logs: set copr build logs url when a build start #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasTomecek
force-pushed
the
set-build-logs-start-build
branch
from
a8e65c5
to
e7da45a
Compare
|
Build failed.
|
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek
force-pushed
the
set-build-logs-start-build
branch
from
e7da45a
to
28e3ce8
Compare
|
Tests passed locally, merging since I wouldn't have time to address comments. |
|
Build succeeded.
|
jpopelka
approved these changes
Feb 20, 2020
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this change, the logs url is set when a build starts, not when it ends
also realised that coprbuildend event worked differently than I thought: so now the status is set correctly in the DB all the time