Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research Packit reverse-dependency checks #2361

Open
5 tasks
lachmanfrantisek opened this issue Mar 5, 2024 · 3 comments
Open
5 tasks

Research Packit reverse-dependency checks #2361

lachmanfrantisek opened this issue Mar 5, 2024 · 3 comments
Assignees
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related.

Comments

@lachmanfrantisek
Copy link
Member

As part of the cross-team discussion about how to help with #2343 , we've come up with an idea how to approach it:

  • Use Fedora on GitLab approach for some projects (we can start with Python package(s) since Lumir was part of the discussion and Python would hugely benefit from this functionality).
  • Use Packit as a CI on merge-requests targeting these projects. (We can start with supporting existing upstream jobs.)
  • Implement the reverse-dependency builds/tests into Packit. (From all possible approaches, this one looked the most promising since we already have the Copr communication in control.)

So, let's try to think about what would it take to do this:

  • Take a look at this approach and write down main tasks and possible issues we might need to resolve if we need to implement this.
  • Write down concerns and riscs of this approach.
  • Think also about possible configuration.
  • Take a look at how we can use Copr for running reverse-dependency builds. (You can get inspired by mass-prebuild or ask Lumir how they are doing this.)
  • Organise a discussion within a team and present the findings.
@majamassarini majamassarini added area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. impact/high This issue impacts multiple/lot of users. gain/high This brings a lot of value to (not strictly a lot of) users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related. labels Mar 7, 2024
@frenzymadness
Copy link

I'm thinking about it and have a question: isn't „Fedora on Gitlab“ too big change to start with? I mean, there are many questions around this and I'm afraid they might block the reverse dependency builds. For example: if a package is onboarded to Gitlab, is pagure disabled for it? If not, what will happen to PRs open via Pagure? What will be UX for the maintainers?

@lachmanfrantisek
Copy link
Member Author

lachmanfrantisek commented Mar 11, 2024

@frenzymadness Good point, Lumír.

A lot is still unclear and that's why I've created this spike card...;)

I don't know many details about the OSCI tooling, but I would say it takes care only of the sync. At least for the start, it would probably be on you, as a maintainer, to disable pull requests on Pagure site if wanted:
image

For us, the difference between GitLab/Pagure from the implementation point of view is not the hardest part of the implementation. If the FedoraOnGitLab won't work, we can do the Pagure support. Maybe the GitLab is just more future-proof. The crucial part is to handle these PRs as dist-git content and the reverse-dep logic itself.

  • For the user, ideally, it shouldn't matter -- it would still be a pull request on a git-forge.
  • Fort the maintainer, it might be messy to review both places. So, it's probably better to allow contribution only in one place and clearly document the process in the other.

@lachmanfrantisek
Copy link
Member Author

Maybe just one concern -- how the user rights can be handled on GitLab. If we force people to create a GitLab account and also if the maintainer permissions can be synced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related.
Projects
Status: in-review
Development

No branches or pull requests

3 participants