Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep tasks in queue when a dependant service is down #25

Closed
TomasTomecek opened this issue Jun 26, 2019 · 8 comments
Closed

keep tasks in queue when a dependant service is down #25

TomasTomecek opened this issue Jun 26, 2019 · 8 comments
Assignees
Labels
good-first-issue Good for newcomers. kind/feature New feature or a request for enhancement. stale Is the issue still valid? triaged This issue was already processed by the team.

Comments

@TomasTomecek
Copy link
Member

TomasTomecek commented Jun 26, 2019

Let's say COPR is down and all the API calls are failing: if such a thing happens we should keep tasks in a queue and process them once we're able to succeed.

Dominika says celery has autoretry which could solve this. https://www.distributedpython.com/2018/09/04/error-handling-retry/

@TomasTomecek TomasTomecek added the kind/feature New feature or a request for enhancement. label Jun 26, 2019
@lachmanfrantisek lachmanfrantisek added this to the next milestone Aug 15, 2019
@lachmanfrantisek lachmanfrantisek added the triaged This issue was already processed by the team. label Aug 15, 2019
@stale
Copy link

stale bot commented Nov 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Is the issue still valid? label Nov 5, 2019
@jpopelka
Copy link
Member

jpopelka commented Nov 8, 2019

Shouldn't be that hard with celery-autoretry, marking as good-first-issue.

@stale stale bot removed the stale Is the issue still valid? label Nov 8, 2019
@jpopelka jpopelka added the good-first-issue Good for newcomers. label Nov 8, 2019
@TomasTomecek
Copy link
Member Author

Actually, this could even be extended to letting the user know that some infrastructure is slow or borked and that's the reason packit is trying to build the RPM for 5 hours.

@TomasTomecek TomasTomecek removed this from the next milestone Nov 21, 2019
@TomasTomecek
Copy link
Member Author

I'd even extend this to not rely on fedora-messaging at all: once we submit a build, we have a new celery task, which would check the build periodically so that we wouldn't need to count on f-m.

@TomasTomecek
Copy link
Member Author

If possible, we shouldn't spam the PR with identical comments - we should only comment once.

Franta says that we should post only a single comment after we try X times and fail to proceed.

@stale
Copy link

stale bot commented Mar 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.
We are doing this to be sure that the issue is still relevant. Anyone can comment to remove the stale state. (The issues marked with pinned, security, bug or EPIC label
are not considered stale.)

@stale stale bot added the stale Is the issue still valid? label Mar 16, 2020
@TomasTomecek TomasTomecek removed the stale Is the issue still valid? label Mar 19, 2020
@stale
Copy link

stale bot commented May 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.
We are doing this to be sure that the issue is still relevant. Anyone can comment to remove the stale state. (The issues marked with pinned, security, bug or EPIC label
are not considered stale.)

@stale stale bot added the stale Is the issue still valid? label May 18, 2020
@csomh csomh removed the stale Is the issue still valid? label May 19, 2020
@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned, security, bug or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Jul 18, 2020
@stale stale bot closed this as completed Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers. kind/feature New feature or a request for enhancement. stale Is the issue still valid? triaged This issue was already processed by the team.
Projects
None yet
Development

No branches or pull requests

5 participants