Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: document that top-level actions are replaced by nested (job) actions (nor merged) #443

Open
pirat89 opened this issue Nov 12, 2021 · 7 comments
Labels
🌞 friday 🤟 Weekend is coming! good-first-issue Good for newcomers. stale Is the issue still valid?

Comments

@pirat89
Copy link
Contributor

pirat89 commented Nov 12, 2021

In case like below:

actions:
  create-archive:
  - ....
  fix-spec-file:
  - ....
  post-upstream-clone:
  - ....

jobs:
- job: copr_build
  trigger: pull_request
  metadata:
    ....
  actions:
    create-archive:
    ....

The actiones under the jobs, replace completely action from the top-level (when the job is triggered). Currently, from the documentation it's not clear, whether in such a case only the create_archive action is replaced and the others (fix-spec-file, post-upstream-clone) are kept untouched, or whether the whole actions section is completely replaced. It's easy to discover the behaviour, but I think the documented behavriou will still save some time.

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Mar 2, 2022
@pirat89
Copy link
Contributor Author

pirat89 commented Mar 2, 2022

I think this is worthy to be solved

@stale stale bot removed the stale Is the issue still valid? label Mar 2, 2022
@stale

This comment was marked as resolved.

@stale stale bot added the stale Is the issue still valid? label May 1, 2022
@lachmanfrantisek lachmanfrantisek removed the stale Is the issue still valid? label May 2, 2022
@lachmanfrantisek lachmanfrantisek transferred this issue from packit/packit May 2, 2022
@lachmanfrantisek
Copy link
Member

Moving this to the documentation repository where this needs to be fixed.

@stale

This comment was marked as outdated.

@stale stale bot added the stale Is the issue still valid? label Jul 10, 2022
@lachmanfrantisek lachmanfrantisek removed the stale Is the issue still valid? label Jul 18, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Sep 21, 2022
@csomh csomh added good-first-issue Good for newcomers. 🌞 friday 🤟 Weekend is coming! and removed stale Is the issue still valid? labels Sep 29, 2022
@stale
Copy link

stale bot commented Jan 8, 2023

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌞 friday 🤟 Weekend is coming! good-first-issue Good for newcomers. stale Is the issue still valid?
Projects
Status: backlog
Development

No branches or pull requests

3 participants