Chapter 5 method xyxyh2xywh

[wvalcke]

In the implementation :

  def xyxyh2xywh(xyxy, image_size=416):
      xywh = torch.zeros(xyxy.shape[0],6)
      xywh[:,2] = (xyxy[:, 0] + xyxy[:, 2]) / 2./img_size
      xywh[:,3] = (xyxy[:, 1] + xyxy[:, 3]) / 2./img_size
      xywh[:,5] = (xyxy[:, 2] - xyxy[:, 0])/img_size 
      xywh[:,4] = (xyxy[:, 3] - xyxy[:, 1])/img_size
      xywh[:,1]= xyxy[:,6]    
      return xywh

i think that it should be

  def xyxyh2xywh(xyxy, image_size=416):
      xywh = torch.zeros(xyxy.shape[0],6)
      xywh[:,2] = (xyxy[:, 0] + xyxy[:, 2]) / 2./img_size
      xywh[:,3] = (xyxy[:, 1] + xyxy[:, 3]) / 2./img_size
      xywh[:,4] = (xyxy[:, 2] - xyxy[:, 0])/img_size 
      xywh[:,5] = (xyxy[:, 3] - xyxy[:, 1])/img_size
      xywh[:,1]= xyxy[:,6]    
      return xywh

[mave5]

Thanks @wvalcke for reporting this bug. You are correct.

[bgpantojar]

@wvalcke what is exactly the difference between the two functions you are showing. For me they are exactly the same, aren't they?

[mralamdari]

The Difference is in replacing places of 4 and 5
So in other words, Turn These:

xywh[:,5] = (xyxy[:, 2] - xyxy[:, 0])/img_size
xywh[:,4] = (xyxy[:, 3] - xyxy[:, 1])/img_size

To These:
xywh[:,4] = (xyxy[:, 2] - xyxy[:, 0])/img_size
xywh[:,5] = (xyxy[:, 3] - xyxy[:, 1])/img_size