Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
time
crate, which is deprecated, replacedtime::precise_time_ns
with standard library'sstd::time::Instant
.I'm not sure if it worsened "smoothness" of emulation. It feels the same after this change. I'm not sure that
std::time::Instant
is as precise astime::precise_time_ns
on most systems. However, it all boils down tothread::sleep
, which can't be very precise, I think, due to nature of schedulers in standard non-realtime OSes, so nanosecond-grade precision for time measurements is probably not as important.To get feeling how
std::time::Instant
works, I ran the following script:It outputs something like this:
So probably quite precise on my system (Mac OS). Not tested on Linux and Windows.