Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't built
sdl2
's dependencyrustc-serialize
on my machine, it fails with following errorSo I updated
sdl2
to latest version.It had breaking changes, especially after 0.30, when
Renderer
was split intoCanvas
andTextureCreator
. Also, nowTexture
has lifetime parameter, but it's not possible to store bothTextureCreator
andTexture
s into the same struct, because they're self-referencing. Because of this, sdl2 now hasunsafe_textures
feature, which is, AFAIK, similar to behavior before 0.30, and it's probably safe to use it as long as textures are not deallocated manually, and looks likerustzx
does not deallocate textures prematurely.However, I'm not sure about regressions, as there are lots of changes in sdl2. For me, it runs very slowly in debug version (in release it's ok). Probably I should first build with first working version of sdl2 and compare.